feat: add check against default branch#1519
Merged
Lee-W merged 1 commit intocommitizen-tools:v4-9-0-testfrom Aug 20, 2025
Merged
feat: add check against default branch#1519Lee-W merged 1 commit intocommitizen-tools:v4-9-0-testfrom
Lee-W merged 1 commit intocommitizen-tools:v4-9-0-testfrom
Conversation
github-actions
bot
added
pr-status: wait-for-review
type: feature
bearomorphism
force-pushed
the
feat-check-from-default
branch
from
93f3c0b to
9627306
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## v4-9-0-test #1519 +/- ##
==============================================
Coverage ? 98.31%
==============================================
Files ? 58
Lines ? 2671
Branches ? 0
==============================================
Hits ? 2626
Misses ? 45
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bearomorphism
force-pushed
the
feat-check-from-default
branch
6 times, most recently
from
8ec2c66 to
3c7623f
Compare
Lee-W
reviewed
Aug 17, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
other than the naming issue, everything looks great. a wonderful feature we should have long ago
Lee-W
added
pr-status: wait-for-modification
and removed
pr-status: wait-for-review
labels
4 tasks
bearomorphism
force-pushed
the
feat-check-from-default
branch
from
3c7623f to
5232634
Compare
Lee-W
approved these changes
Aug 19, 2025
Member
Lee-W
left a comment
Lee-W
left a comment
There was a problem hiding this comment.
one nitpick. but overall looks great!
tests/test_git.py
Outdated
| assert result == expected_cmd | ||
|
|
||
|
|
||
| def test_get_default_branch(mocker: MockFixture): |
Member
There was a problem hiding this comment.
This should be separate as 2 test cases instead
Collaborator
Author
There was a problem hiding this comment.
done, please review
bearomorphism
force-pushed
the
feat-check-from-default
branch
from
5232634 to
264c2d0
Compare
Lee-W
approved these changes
Aug 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related PR: #1400
Wait for #1472 and #1457
Related issue: #1498
cz check --default-range.Some TODOs
Checklist